-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade dependencies #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this! LGTM, except for a small detail about how we generate changelogs.
CHANGELOG.md
Outdated
### Unreleased | ||
|
||
## Changed | ||
|
||
- browser support now matches the `@dittolive/ditto` package. see [Ditto's | ||
documentation](https://docs.ditto.live/compatibility/js-web) | ||
([#56](https://github.com/getditto/react-ditto/pull/56)) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the lack of docs in this regard, but for the last few releases, we've been using conventional commits and standard-version
to generate this changelog. I tried running it again (npx standard-version
) to see what would happen with this manually added entry and it resulted in this:
### [0.11.1](https://github.com/getditto/react-ditto/compare/v0.11.0...v0.11.1) (2024-04-18)
### Bug Fixes
* remove implicit dependency on `lodash` ([9b56f93](https://github.com/getditto/react-ditto/commit/9b56f9331de4e5718478717d0c9527dca2764d15))
## [0.11.0](https://github.com/getditto/react-ditto/compare/v0.11.0-alpha.0...v0.11.0) (2023-03-22)
### Unreleased
## Changed
- browser support now matches the `@dittolive/ditto` package. see [Ditto's
documentation](https://docs.ditto.live/compatibility/js-web)
([#56](https://github.com/getditto/react-ditto/pull/56))
Since this PR mainly focuses on upgrading dependencies, I wouldn't want to rewrite the whole PR's commit message when merging it just to see a new entry in the changelog. Is there a chance we could separate/reword this change to use a properly formatted commit message? Let me know if you have other ideas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I just saw the changelog and wanted to add to it. I will remove that change and update the PR title to use the standard-version syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, adding the markdown link to the documentation in the PR title sure looks wonky. I can squash-merge the PR with a commit message
chore: match supported browsers with the `@dittolive/ditto` package. see [Ditto's documentation](https://docs.ditto.live/compatibility/js-web) for details.
does that work? It will hide the actual (internal) changes of this PR but at least it doesn't break the changelog tool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think that works. I'd just like to point out that only commits marked with feat
and fix
will make it to the changelog, so if you want to have that message show there you should pick one of those; if not, chore
seems fine to me too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
react
andreact-dom
dev-dependencies (were pinned to v18.0.0),karma.conf.js
to.eslintignore
as the project is using a Typescript linter,karma-typescript
to handle ES2020 syntax used bycbor
library (fixes Errors running tests using NPM #48),Example project
TextEncoder
polyfill required for JSDom to support @dittolive/ditto.CI
To be squash-merged.